Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] date and datetime types in darkmode #2379

Closed
2 tasks done
daveteu opened this issue Aug 16, 2021 · 3 comments
Closed
2 tasks done

[DataGrid] date and datetime types in darkmode #2379

daveteu opened this issue Aug 16, 2021 · 3 comments
Labels
component: data grid This is the name of the generic UI component, not the React module! v5.x

Comments

@daveteu
Copy link

daveteu commented Aug 16, 2021

  • The issue is present in the latest release.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 馃槸

In DataGrid, when using date and dateTime types, the Date and DateTimePicker components are not respecting palette.darkmode

image

Expected Behavior 馃

Picker should respect theme colors

This behavior can also be observed on Mui Documentations - https://material-ui.com/components/data-grid/editing/#controlled-editing

Your Environment 馃寧

System: System
 System:
    OS: macOS 11.4
  Binaries:
    Node: 16.5.0 - ~/.nvm/versions/node/v16.5.0/bin/node
    Yarn: Not Found
    npm: 7.19.1 - ~/.nvm/versions/node/v16.5.0/bin/npm
  Browsers:
    Chrome: 92.0.4515.131
    Edge: Not Found
    Firefox: Not Found
    Safari: 14.1.1
  npmPackages:
    @material-ui/core: ^5.0.0-beta.2 => 5.0.0-beta.2 
    @material-ui/data-grid: ^4.0.0-alpha.37 => 4.0.0-alpha.37 
    @material-ui/icons: ^5.0.0-beta.1 => 5.0.0-beta.1 
    @material-ui/lab: ^5.0.0-alpha.41 => 5.0.0-alpha.41 
    @material-ui/private-theming:  5.0.0-beta.2 
    @material-ui/styled-engine-sc: ^5.0.0-beta.1 => 5.0.0-beta.1 
    @material-ui/styles: ^5.0.0-beta.2 => 5.0.0-beta.2 
    @material-ui/system:  5.0.0-beta.2 
    @material-ui/types:  6.0.1 
    @material-ui/unstyled:  5.0.0-alpha.41 
    @material-ui/utils:  5.0.0-beta.1 
    @types/react: ^17.0.0 => 17.0.11 
    react: ^17.0.2 => 17.0.2 
    react-dom: ^17.0.2 => 17.0.2 
    styled-components: ^5.3.0 => 5.3.0 
    typescript: ^4.1.3 => 4.3.2 

@eps1lon eps1lon transferred this issue from mui/material-ui Aug 16, 2021
@oliviertassinari
Copy link
Member

Capture d鈥檈虂cran 2021-08-16 a虁 16 29 23

Duplicate of mui/material-ui#25016

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists labels Aug 16, 2021
@oliviertassinari oliviertassinari added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed duplicate This issue or pull request already exists labels Aug 16, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 21, 2021

I think that we can solve this issue the same way we will #1805: with mui/material-ui#25016, and using the CssBaseline component. In the meantime, the workaround is trivial https://codesandbox.io/s/material-demo-forked-2iwpd?file=/demo.tsx

@oliviertassinari oliviertassinari added v5.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 21, 2021
@oliviertassinari oliviertassinari changed the title Datagrid - date and datetime types (darkmode) [DataGrid] date and datetime types in darkmode Aug 21, 2021
@m4theushw
Copy link
Member

Fixed by mui/material-ui#25016.

You need to use <CssBaseline enableColorScheme /> in your theme. See https://mui.com/components/css-baseline/#page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! v5.x
Projects
None yet
Development

No branches or pull requests

3 participants