Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove disableExtendRowFullWidth prop #4308

Closed
Tracked by #3287
alexfauquette opened this issue Mar 29, 2022 · 2 comments · Fixed by #7373
Closed
Tracked by #3287

[data grid] Remove disableExtendRowFullWidth prop #4308

alexfauquette opened this issue Mar 29, 2022 · 2 comments · Fixed by #7373
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request

Comments

@alexfauquette
Copy link
Member

alexfauquette commented Mar 29, 2022

Shouldn't we fix disableExtendRowFullWidth too? Reading its description seems that we're supporting partially it = only removing the last border. If the description is correct, disableExtendRowFullWidth=false should behave like if the last column had flex=1.

* If `true`, rows will not be extended to fill the full width of the grid container.
* @default false
*/
disableExtendRowFullWidth: boolean;

Currently, it gives the impression that the row is extending the full width, but once the cell is clicked I see its true width.

image

Changing the way disableExtendRowFullWidth works can be a breaking change, it depends on how we see its behavior.

Originally posted by @m4theushw in #4224 (review)

Observations

To do it, we should care about the column resizing which implies two levels of modification:

  1. In initialization the last visible column with is replaced by flex 1, such that its width will fill the remaining space
  2. When resizing the last column is updated to be sure that the last column fills the space. This brings questions about how can new modify the last column width
@flaviendelangle
Copy link
Member

Maybe put a shorter issue title 😄

@alexfauquette alexfauquette changed the title Shouldn't we fix disableExtendRowFullWidth too? Reading its description seems that we're supporting partially it = only removing the last border. If the description is correct, disableExtendRowFullWidth=false should behave like if the last column had flex=1. Fix disableExtendRowFullWidth to be equivalent to flex=1 on last column Mar 29, 2022
@flaviendelangle flaviendelangle changed the title Fix disableExtendRowFullWidth to be equivalent to flex=1 on last column [data-grid] Fix disableExtendRowFullWidth to be equivalent to flex=1 on last column Mar 29, 2022
@flaviendelangle flaviendelangle added the component: data grid This is the name of the generic UI component, not the React module! label Mar 29, 2022
@alexfauquette alexfauquette added new feature New feature or request waiting for 👍 Waiting for upvotes labels Mar 29, 2022
@cherniavskii
Copy link
Member

We came to the conclusion that we can remove the disableExtendRowFullWidth prop because it's confusing and doesn't seem to provide much value.

@MBilalShafi MBilalShafi removed the waiting for 👍 Waiting for upvotes label Jan 2, 2023
@MBilalShafi MBilalShafi self-assigned this Jan 2, 2023
@MBilalShafi MBilalShafi changed the title [data-grid] Fix disableExtendRowFullWidth to be equivalent to flex=1 on last column [data-grid] Remove disableExtendRowFullWidth prop Jan 2, 2023
@MBilalShafi MBilalShafi changed the title [data-grid] Remove disableExtendRowFullWidth prop [data grid] Remove disableExtendRowFullWidth prop Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants