Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Use Babel #50

Closed
1 of 4 tasks
oliviertassinari opened this issue Jul 7, 2020 · 3 comments · Fixed by #3965
Closed
1 of 4 tasks

[RFC] Use Babel #50

oliviertassinari opened this issue Jul 7, 2020 · 3 comments · Fixed by #3965
Labels
core Infrastructure work going on behind the scenes RFC Request For Comments
Milestone

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 7, 2020

In order to build on top of the same foundation and to save time, I think that we should reuse the existing build steps of the main repository by leveraging Babel. It appears that reproducing the same building pipeline will provide the maximum consistency. For instance

@oliviertassinari oliviertassinari added this to the Post MVP milestone Jul 7, 2020
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 8, 2020

This also includes replacing rollup-plugin-typescript2 in favor of @rollup/plugin-babel.

@dtassone
Copy link
Member

This also includes replacing rollup-plugin-typescript2 in favor of @rollup/plugin-babel.

Can we use both?
How are we going to check the types without typescript?

This is my main concern with Babel.
We need compile errors for issues with types.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 30, 2020

How are we going to check the types without typescript?

@dtassone It depends on what you have in mind.

  • If you are referring to the CI. The solution is to run the TypeScript linter, for instance.
  • If you are referring to get TypeScript fails when developing, we don't want that, it slows down the speed of iteration. We don't block the build because eslint fails. Instead, we look at the warning in the IDE and we fix them in time. Shouldn't it be the same with TypeScript? See Opting out of typescript checks in Next 9.0+ vercel/next.js#7687 for more details.

Notice that we need to do run a TypeScript linter (outside of the build step) no matter what, to run the future TypeScript focused tests. For instance:

@cherniavskii cherniavskii added the core Infrastructure work going on behind the scenes label Feb 8, 2022
@oliviertassinari oliviertassinari added the RFC Request For Comments label Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes RFC Request For Comments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants