Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Explanation around the getRowId is not great #5126

Closed
flaviendelangle opened this issue Jun 6, 2022 · 0 comments · Fixed by #5156
Closed

[docs] Explanation around the getRowId is not great #5126

flaviendelangle opened this issue Jun 6, 2022 · 0 comments · Fixed by #5156
Assignees
@flaviendelangle
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation

Comments

@flaviendelangle
Copy link
Member

Current doc

image

Goal

  1. Say that this prop should be memoized
  2. Explain how to handle a dataset without a unique id
@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 6, 2022
@flaviendelangle flaviendelangle mentioned this issue Jun 9, 2022
Merged
@flaviendelangle flaviendelangle self-assigned this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs] Improve the getRowId doc section flaviendelangle/mui-x
1 participant
@flaviendelangle