-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGridPro] column resize handles are not keyboard accessible #699
Comments
@petermikitsh Do you have an example of a data grid that supports it? I personally think that we should close as "won't fix". From my perspective, if an end-user needs a screenreader, he doesn't care about how the cells are layout, the SR will read the content for him. I also have no idea how the UX could actually be made to be great. |
I took a look at a few other implementations. None supported keyboard-driven column resizing. |
I have added the |
I do - ag-grid does this properly. Keyboard navigation isn't just for people with disabilities, it is for keyboard only users. https://www.ag-grid.com/react-data-grid/keyboard-navigation/ I have another ticket in, discussing this: If you TAB into a grid, it should start by focusing the first cell, then the menu button (to allow for keyboard navigation into the menu items) and then tab focuses the next cell . SHIFT+TAB goes the opposite way. If a user is focused on a cell (enter press goes through sort states like it does today) CTRL+RIGHT / LEFT arrow will resize the column in small increments. Ag-grid doesn't do this part, but they provide for an extension point with the "suppressHeaderKeyboardEvent". This is nice because, the grid will work the way I suggest by default, but if any custom behavior is required (and the ctrl+arrow functions are custom) the dev can provide their own pure function that returns true or false, allowing for custom behavior. I was able to do this with Ag-grid pretty quickly. I think mui-x should follow this idea - providing a WCAG out of the box keyboard a11y, and an extension point for other cases that can't be predicted. |
@httpete I feel like we are going on a tangent. This issue is specifically about keyboard support for column resizing. For generic keyboard support, please refer to https://www.w3.org/TR/wai-aria-practices/#dataGrid. I would encourage to have a dive into the content as I feel they argue for a different approach than you do. They encourage the grid to be a single step in the tab sequence (what we have implemented, not multiple ones). As an end-user, I would personally expect Command + Arrow Left, to move me to my previous page in the history, and Control + Arrow Left to move to my next window workspace. I'm on macOS I think that we can use #3015 to make sure we allow developers to implement a custom logic on their own. |
I feel it all comes under the discussion of how keyboard a11y should work. |
Current Behavior 馃槸
Expected Behavior 馃
Steps to Reproduce 馃暪
Steps:
Context 馃敠
This is partially an accessibility question, and may not be a bug.
I'm not an a11y expert, but my understanding is all controls should at least be keyboard focusable.
But the broader question remains: what should the acceptance criteria be for column resizers and a11y? It may be possible this current implementation is considered accessible, and there is no bug.
The text was updated successfully, but these errors were encountered: