Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TimePicker] uncontrolled timepicker doesn't work #7514

Closed
hmeerlo opened this issue Mar 25, 2016 · 0 comments
Closed

[TimePicker] uncontrolled timepicker doesn't work #7514

hmeerlo opened this issue Mar 25, 2016 · 0 comments
Labels
component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component.

Comments

@hmeerlo
Copy link

hmeerlo commented Mar 25, 2016

Problem Description

I just tried out 0.15.0-alpha.2 and found out that my TimePicker's no longer function. All TimePickers are regarded as controlled instances because the following function is incorrect:

  _isControlled() {
    return this.props.value !== null;
  },

So if value is undefined (which it is in my case because I set defaultTime) then the picker thinks it is a controlled instance.

Versions

  • Material-UI: 0.15.0-alpha.2
  • React: 0.14.7
  • Browser: Chrome 49.0.2623.87
@aahan96 aahan96 closed this as completed Jul 5, 2016
@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 21, 2022
@zannager zannager transferred this issue from mui/material-ui Jan 13, 2023
@zannager zannager added component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants