Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][Datepicker] Demo AdapterHijri requires tslib #8205

Closed
1 task done
nameetrajore opened this issue Mar 10, 2023 · 4 comments
Closed
1 task done

[docs][Datepicker] Demo AdapterHijri requires tslib #8205

nameetrajore opened this issue Mar 10, 2023 · 4 comments
Labels
component: pickers This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it support: docs-feedback Feedback from documentation page

Comments

@nameetrajore
Copy link

nameetrajore commented Mar 10, 2023

Steps to Reproduce

  1. Visit https://mui.com/x/react-date-pickers/calendar-systems/
  2. ??
  3. demo AdapterHijri crashes

Your Environment

Tech Version
MUI v6.0.1
Netlify deploy https://640a2a1f4874c30008aa2914--material-ui-x.netlify.app
Browser Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/109.0
@hbjORbj hbjORbj changed the title [docs] Demo AdapterHijri crashes [docs][Datepicker] Demo AdapterHijri crashes Mar 10, 2023
@hbjORbj hbjORbj added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Mar 10, 2023
@ZeeshanTamboli ZeeshanTamboli transferred this issue from mui/material-ui Mar 11, 2023
@HeVictor
Copy link

Can confirm from my side that both demos hosted on CodeSandbox and StackBlitz are crashing for AdapterHijri, and both are showing errors about not being able to find the tslib dependency:

Screen Shot 2023-03-11 at 5 22 29 pm

Screen Shot 2023-03-11 at 5 22 47 pm

Installing the tslib package like the errors suggest by adding an explicit dependency does resolve the error, but I assume that's not the solution here as I tried copying the same example code onto my VS Code and it was able to build and run properly without adding this explicit dependency. Further digging on why the example fails on the hosted platforms will most likely be needed

@flaviendelangle flaviendelangle removed their assignment Mar 13, 2023
@LukasTy LukasTy changed the title [docs][Datepicker] Demo AdapterHijri crashes [docs][Datepicker] Demo AdapterHijri requires tslib Mar 13, 2023
@LukasTy
Copy link
Member

LukasTy commented Mar 13, 2023

Thank you for opening this issue.

Technically the demo is not crashing, but specifying that it is missing a package to successfully run.

IMHO, this is an issue from @date-io/hijri package, because the built version does contain tslib in its code, but the dependency is not listed.
Ideally, either the build process or the code should be adjusted to avoid adding tslib as an import in favour of native JS code.

@LukasTy LukasTy added external dependency Blocked by external dependency, we can’t do anything about it component: pickers This is the name of the generic UI component, not the React module! support: docs-feedback Feedback from documentation page and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Mar 13, 2023
@HeVictor
Copy link

Good call-out, I believe this issue on the date-io project itself is referring to the problem we are seeing right now. It is marked as closed but I suppose it hasn't really been resolved yet

@LukasTy
Copy link
Member

LukasTy commented May 1, 2023

Closing this issue as all the relevant adapters have been moved into mui-x repository and the mentioned problem is no longer reproducible starting with v6.3.0. 👌

@LukasTy LukasTy closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! external dependency Blocked by external dependency, we can’t do anything about it support: docs-feedback Feedback from documentation page
Projects
None yet
Development

No branches or pull requests

6 participants