Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Update toolbar spacing and design #9090

Open
LukasTy opened this issue May 23, 2023 · 1 comment
Open

[pickers] Update toolbar spacing and design #9090

LukasTy opened this issue May 23, 2023 · 1 comment
Labels
component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v7.x

Comments

@LukasTy
Copy link
Member

LukasTy commented May 23, 2023

Created from #8851 (comment)

We have done some spacing tweaks that emphasize the issue of our picker toolbar spacing.

The current design already has some issues:

  • Some touch targets are way too small (i.e. year view button, meridiem (am/pm) buttons)
    Screenshot 2023-05-23 at 15 56 05
  • The DateTimePicker toolbar is the biggest offender as it already has issue of not supporting/fitting all views. Adding seconds views breaks the layout. What will we do when we will have to handle milliseconds as well?
    Screenshot 2023-05-23 at 15 57 39

Challenges:

  • We can't just add space-between date calendar days to achieve consistent spacing, because someone might already rely on the fact, that the margin can even be disabled via the disableMargin prop.
  • We should not forget that we also have the option to toggle orientation="landscape" and that should look at least somewhat ok. Although, we can probably continue having exceptions on it, like not supporting it if the seconds view is specified.

Ideas

@LukasTy LukasTy added component: pickers This is the name of the generic UI component, not the React module! design: ux labels May 23, 2023
@oliviertassinari
Copy link
Member

I think that it would be great to start exploring moving to Material Design v3, this issue could help us take steps there.

@LukasTy LukasTy added the v7.x label Jul 3, 2023
@oliviertassinari oliviertassinari added design This is about UI or UX design, please involve a designer and removed design: ux labels Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer v7.x
Projects
None yet
Development

No branches or pull requests

3 participants