Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Propagate pnpm engine in package.json #126

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 7, 2024

See mui/mui-public#157

This broke the CI as it wasn't correctly initializing corepack when not in browser mode. The CI was running with a different pnpm version. I fixed this the same way as Toolpad/core/base/X

mui/mui-public#157

Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot marked this pull request as ready for review June 7, 2024 15:22
@zannager zannager added the scope: code-infra Specific to the core-infra product label Jun 10, 2024
@zannager zannager requested a review from mnajdova June 10, 2024 11:37
@Janpot
Copy link
Member Author

Janpot commented Jun 17, 2024

fyi, I don't have write access to this repo, a maintainer will have to merge this

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 20, 2024
@siriwatknp
Copy link
Member

I did update some part in #150

@siriwatknp siriwatknp merged commit 0f14c19 into mui:master Jun 20, 2024
11 of 12 checks passed
@Janpot Janpot deleted the patch-1 branch June 20, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants