Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Most sensible upgrade path from MUI 4 to 6 #141

Open
kabforks opened this issue Jun 14, 2024 · 1 comment
Open

Most sensible upgrade path from MUI 4 to 6 #141

kabforks opened this issue Jun 14, 2024 · 1 comment
Assignees
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. status: waiting for maintainer These issues haven't been looked at yet by a maintainer

Comments

@kabforks
Copy link

kabforks commented Jun 14, 2024

Hello!

I'm very, very excited for Pigment CSS!

However, it's a little unclear to me what the best path forward is, for a MUI 4 app. My employer made me maintainer for this React 16 + MUI 4. So right now I'm upgrading React, Routers, Store etc, and of course, MUI.

The entire app uses "makeStyles", and there are no styled components at all (no imports of styled). Having soon upgraded this to MUI 5, what can I expect of challenges going to MUI 6?

I read that:

The processor looks through the source code for styled(), css(), and other function calls and extracts the arguments to be evaluated. These values are then handed back to Pigment CSS for additional parsing and evaluation.

Does it look through makeStyles ? I've read through https://mui.com/blog/introducing-pigment-css/ and it doesn't mention makeStyles at all.

Thanks for any input on this matter 😊

Search keywords:

@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Jun 14, 2024
@zannager zannager added the package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. label Jun 14, 2024
@kabforks
Copy link
Author

Friendly nudge 😎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: styles Specific to @mui/styles. Legacy package, @material-ui/styled-engine is taking over in v5. status: waiting for maintainer These issues haven't been looked at yet by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants