Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mui-col-#{$class}-pull(push)-#{$i} doesn't work #65

Closed
ghostpanda opened this issue Jan 16, 2016 · 4 comments
Closed

.mui-col-#{$class}-pull(push)-#{$i} doesn't work #65

ghostpanda opened this issue Jan 16, 2016 · 4 comments

Comments

@ghostpanda
Copy link

@mixin mui-make-grid-columns($i: 1, $list: ".mui-col-xs-#{$i}, .mui-col-sm-#{$i}, .mui-col-md-#{$i}, .mui-col-lg-#{$i}") {
  @for $i from (1 + 1) through $mui-grid-columns {
    $list: "#{$list}, .mui-col-xs-#{$i}, .mui-col-sm-#{$i}, .mui-col-md-#{$i}, .mui-col-lg-#{$i}";
  }

  #{$list} {
    position: relative;
    // Prevent columns from collapsing when empty
    min-height: 1px;

    // Inner gutter via padding
    padding-left:  ($mui-grid-gutter-width / 2);
    padding-right: ($mui-grid-gutter-width / 2);
  }
}

.mui-col-lg没有使用position: relative;
导致.mui-col-#{$class}-pull(push)-#{$i} 无法正常工作。
是疏忽了,还是有别的用意?

@amorey
Copy link
Member

amorey commented Jan 16, 2016

This was copied over from Bootstrap's grid system but isn't currently being used. Do you need push/pull in the grid system for a project you're working on?

@ghostpanda
Copy link
Author

https://github.com/twbs/bootstrap-sass/blob/master/assets/stylesheets/bootstrap/mixins/_grid-framework.scss
line : 12
you may lost this 😃

by the way - may i speak Chinese?

@amorey
Copy link
Member

amorey commented Jan 16, 2016

Sorry, I don't speak Chinese! I can try to use Google translate though.

Do you need push/pull for a specific project? We're trying to keep MUI as small as possible so my preference is for leaving it out unless it's necessary. How many more bytes does it add to the output?

@ghostpanda
Copy link
Author

我赞同你的观点,就我个人而言,我push/pull用的很少。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants