Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regeneration of gamelist for pc/*.conf files does not find cached entries when pc/*.conf filecontent is edited #333

Open
Gemba opened this issue Feb 27, 2022 · 0 comments

Comments

@Gemba
Copy link

Gemba commented Feb 27, 2022

Describe the bug
Scraping info is dangling/orphaned in cache/db.xml when editing pc/*.conf files and updating from cache only (Skyscraper -p pc).

To Reproduce

  1. Create a *.conf file in platform pc/ for a well known PC game (i.e., one which has scraping info in the online databases)
  2. Scrape as usual from the different scraping sources with Skyscraper (with -s ...). gamelist gets created as expected with scraping data for that game
  3. Change the content of the *.conf file
  4. Run Skyscraper from cache to generate gamelist again (without -s)
  5. Identified: Information of the game relating to the created *.conf file does not show up in generated gamelist.xml
  6. Expected: gamelist.xml gets created with the game scraping info from cache.

Technical information

  • Skyscraper version: 3.6.15
  • OS: RetroPie 4.7.21 / Raspi OS Buster

Additional context
*.conf filecontent may be volatile until a proper config is found by the user and may be changed far more frequently than the *.conf filename itself.
I assume the effect comes from the fact that the .conf extension is not listed in this codesegment:
https://github.com/muldjord/skyscraper/blob/master/src/nametools.cpp#L494

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant