Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "inbound traffic" from plugin not working #426

Open
rngkll opened this issue Sep 4, 2020 · 0 comments
Open

Disable "inbound traffic" from plugin not working #426

rngkll opened this issue Sep 4, 2020 · 0 comments

Comments

@rngkll
Copy link

rngkll commented Sep 4, 2020

while trying to disable inbound traffic from maven plugin, we see that it enables by default and set the first domain for the cluster.

enabling in the UI is possible but not from maven plugin, we tried as well with AMC application manager with same result when we modify the json to have a null value, example: "inbound": {"publicUrl":null}

when checking the code of the plugin the code for RequestBuilder.java specifies the following.

private String resolveUrl(RuntimeFabricDeploymentSettings deploymentSettings, String targetId) {
JsonArray domains = client.getDomainInfo(targetId);
if (deploymentSettings.getPublicUrl() == null && domains.size() > 0) {
String domain = domains.get(0).getAsString();
return domain.replace(DOMAIN_WILDCARD, deployment.getApplicationName());
} else {
return deploymentSettings.getPublicUrl();
}
}

which explain the behavior explained above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant