Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-Peer Code Review #2

Open
Peter1907 opened this issue Aug 12, 2022 · 1 comment
Open

Peer-to-Peer Code Review #2

Peter1907 opened this issue Aug 12, 2022 · 1 comment

Comments

@Peter1907
Copy link

Amazing job implementing the add & remove functions.
Your code clean & really readable.
One thing I noticed, that could make the code even better, is to use template literals to writhe a whole HTML-block inside a specific HTML-element, instead of creating & appending each element from scratch.

@cmolinan
Copy link

cmolinan commented Aug 12, 2022

I'm watching the progress of your addremove branch
You're doing a great job. Even using Classes !!.

I send you some suggestions for improvements to be made, which you yourself will surely discover

  1. Do not add empty tasks (without text)
  2. It might be interesting if you add the option to add the tasks with an Enter key as well.
  3. After adding the new task, delete the content of the input
  4. When activating the edition, the cursor of the current text should jump to the end of the text, as to be able to continue writing or delete some text
  5. Sometimes, it doesn't delete the current item, but the previous one.
    Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants