Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version change popup #4232

Closed
wants to merge 22 commits into from
Closed

Version change popup #4232

wants to merge 22 commits into from

Conversation

sajacl
Copy link
Contributor

@sajacl sajacl commented Dec 19, 2022 •
edited

  1. Add changes.txt.
  2. Update GUI by introducing some views and handlers.
    1. Introduce ChangeLogTableCellView, ChangeLogContentView, ChangeLogViewController.
    2. Introduce ChangeLogUIHandler.
    3. Add FormSheet handlers.
    4. Introduce FormSheetConfiguration.
  3. Introduce ChangeLog.
  4. Introduce ReadChangesOperation.
  5. Introduce ProcessEnvironment+Extension.

This change is Reviewable

@sajacl
Add VersionNotifierTableCellView.
5fbef55
@sajacl
Add VersionNotifierContentView.
75f5e5f
@sajacl
Add VersionNotifierViewController.
72a4e67
@sajacl
Add changes.txt and rename VersionNotifier to ChangeLogNotifier.
bf27cda
@sajacl
Introduce ChangeLogNotifierUIHandler and conform SceneDelegate to…
b1f5f85 
… new protocol.
@sajacl
Introduce VersionChangeLogReaderOperation.
f187469
@sajacl
Swift format update.
024a7a1
@sajacl
Adopt userInterfaceIdiom for presenting popup.
f4e59b8
@sajacl
Add Form Sheet Custom Handlers.
63eb098 
`FormsheetTransitioningDelegate`,
`FormsheetPresentationController`,
`FormsheetPresentationAnimator`.
@sajacl
Introduce FormSheetConfiguration.
f06b86a
@sajacl
Update naming.
bc2975c
@sajacl
Improve namings.
fc80133
@sajacl
Adopt scene delegate to FormSheet.
3539c0b
@sajacl
Add ChangeLog.
28fa854
@sajacl
Introduce ProcessEnvironment+Extension.
6254631
@sajacl
Add ReadChangesOperation to AppDelegate in order to handle show c…
e4b6b04 
…hanges.
@sajacl
Merge branch 'master' into version-change-popup
83b68a1
@sajacl
Update showing change log logic.
6590c48
@sajacl
Adopt ChangeLog changes.
f58c659
@sajacl
Removed dummy changes.
76f345f
@sajacl
Disabled force show changelog.
4c4b91d
@sajacl
Update mark.
7ae8cfd
@sajacl sajacl self-assigned this Dec 19, 2022
@pronebird
Copy link
Contributor

Changelog support was merged in b2f8541

@pronebird pronebird closed this Mar 28, 2023
@pronebird pronebird deleted the version-change-popup branch March 28, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pronebird pronebird Awaiting requested review from pronebird

Assignees

@sajacl sajacl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sajacl @pronebird