Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 [Bug] WebpackError: ReferenceError: window is not defined #229

Closed
19 tasks
tuliooassis opened this issue Jun 2, 2020 · 3 comments
Closed
19 tasks
Assignees
Labels
bug Something isn't working invalid This doesn't seem right
Projects

Comments

@tuliooassis
Copy link
Member

User Story (if applicable)

As a
I want to
So that

Description

Describe the bug with a clear and concise description of what it is:

  • Error;
  • Impact;
  • Consequence;
  • How to fix;
  • Effort to fix.

Assumptions

Optionally, add assumptions here.

Steps to reproduce the behavior:

  1. Go/navigate to '...';
  2. Click/inspect on '....';
  3. Scroll down to '....';
  4. See error.

Expected behavior

(A clear and concise description of what you expected to happen)

Screenshots

image

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Mobile (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Acceptance criteria

  • 1. User should...
    Given
    When
    Then

Test scenarios

Add test scenarios.

E.g. try to reproduce this bug in devices like X and browsers like Y, feature toggle on/off...

Additional context

(Add any other context about the problem here, like screenshots)

Checklist do kickoff

  • A an谩lise da hist贸ria est谩 conclu铆da?
  • QA (ou pessoa que assumiu o papel de QA) revisou a an谩lise?
  • A hist贸ria est谩 completa com todos os detalhes e as informa莽玫es relevantes?
    (Ex.: Contexto, Escopo, Fora de Escopo, Crit茅rios de aceite, etc);
  • O valor de neg贸cio da hist贸ria est谩 bem entendido? (se aplic谩vel)
  • Esta hist贸ria n茫o tem depend锚ncia de outras hist贸rias futuras?
  • N茫o existem d铆vidas t茅cnicas (d茅bitos t茅cnicos) relacionadas a hist贸ria;
  • H谩 prot贸tipos de telas para essa hist贸ria (se aplic谩vel)
  • H谩 detalhes na hist贸ria de mensagens de erro e outros feedbacks para o usu谩rio (se aplic谩vel)
  • H谩 mensagens de ajuda ou outros textos definidos na hist贸ria (se aplic谩vel)
  • A hist贸ria est谩 em um tamanho adequado
  • Existe feature toggle para a feature (se aplic谩vel)

Checklist do deskcheck

  • H谩 testes unit谩rios que validem a implementa莽茫o? (se aplic谩vel)
  • As altera莽玫es de c贸digo passaram em todas as pipelines
  • A hist贸ria foi executada manualmente
  • A hist贸ria n茫o trouxe regress玫es ou impacto negativo a outras implementa莽玫es
  • Todos os crit茅rios de aceite foram cobertos
  • A hist贸ria n茫o precisa de feedback ou corre莽茫o
  • Foi testada uma jornada completa do usu谩rio atrav茅s da hist贸ria (se aplic谩vel)
@tuliooassis tuliooassis added bug Something isn't working invalid This doesn't seem right labels Jun 2, 2020
@jimmyandrade
Copy link
Member

jimmyandrade commented Jun 2, 2020

@tuliooassis Veja isso: gatsbyjs/gatsby#309. Talvez possa ajudar.

@tuliooassis
Copy link
Member Author

@jimmyandrade
Verifiquei e vi que a causa foi a atualiza莽茫o da recoil neste merge.

Encontrei tamb茅m uma issue no repo da lib.

Acredito que voltar para a vers茫o 0.0.7 resolver谩. O que acha?

@jimmyandrade
Copy link
Member

jimmyandrade commented Jun 2, 2020

@tuliooassis acho excelente! Parab茅ns e obrigado por ter achado esse problema! <3

Acabei de subir o commit a2c69d2, que volta para a vers茫o 0.0.7 at茅 o pessoal resolver isso. Nesse commit, tamb茅m pedi ao Renovate para passar a ignorar updates do Recoil, para n茫o corrermos o risco de ter esse problema de novo.

J谩 at茅 fizeram uma PR em facebookexperimental/Recoil#220 (e uma duplicata em facebookexperimental/Recoil#233) para resolver isso. Vou acompanhar de perto e, quando lan莽arem uma corre莽茫o (provavelmente na 0.0.9), a gente atualiza manualmente.

@jimmyandrade jimmyandrade added this to Backlog in Multei via automation Jun 2, 2020
@jimmyandrade jimmyandrade linked a pull request Jun 2, 2020 that will close this issue
1 task
@tuliooassis tuliooassis moved this from Backlog to Done in Multei Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
Multei
  
Done
Development

No branches or pull requests

2 participants