Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types to appease mypy! #56

Closed
bh2smith opened this issue Nov 17, 2022 · 2 comments
Closed

Add types to appease mypy! #56

bh2smith opened this issue Nov 17, 2022 · 2 comments

Comments

@bh2smith
Copy link
Contributor

Mypy complains and I have to silence it like this (which is not ideal).

from multiformats_cid import from_bytes  # type: ignore

If the project is already typed, then it should be as easy as adding an empty file called py.typed to the base module.

and adding this to setup configuration:

[options.package_data]
<YOUR_SRC_DIR> = py.typed

However, I went looking for the code here and I don't see any:

Screenshot 2022-11-17 at 12 12 34

@bh2smith bh2smith changed the title Add Types to Appease mypy! Add types to appease mypy! Nov 17, 2022
@bh2smith
Copy link
Contributor Author

From what I can tell, there is only one file in this project (although it doesn't appear to be here).

Screenshot 2022-11-17 at 12 19 42

If someone could link me to it I can add the types.

@rvagg
Copy link
Member

rvagg commented Nov 18, 2022

Seems like you've found the right place to post this.

@rvagg rvagg closed this as completed Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants