Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

race condition in NegotiateLazy #83

Closed
marten-seemann opened this issue Apr 21, 2022 · 1 comment
Closed

race condition in NegotiateLazy #83

marten-seemann opened this issue Apr 21, 2022 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@marten-seemann
Copy link
Contributor

Race condition in NegotiateLazy: If one protocol is unsupported, we need to send an "na". However, we try to do this concurrently with parsing of the next token. If parsing of the next token errored, we'd close the connection, leading to the "na" being written on a closed connection.
@marten-seemann marten-seemann added the kind/bug A bug in existing code (including security flaws) label Apr 21, 2022
@marten-seemann marten-seemann mentioned this issue Apr 21, 2022
Merged
@marten-seemann
Copy link
Contributor Author

NegotiateLazy was removed in #92.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marten-seemann