Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

Commit

Permalink
Merge pull request #393 from multinet-app/no-403
Browse files Browse the repository at this point in the history
Don't use HTTP 403 to indicate that no one is logged in
  • Loading branch information
waxlamp committed May 29, 2020
2 parents de07f67 + 940e3fe commit 0a6dcf8
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions multinet/auth/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from flasgger import swag_from
from flask import make_response, session
from flask.blueprints import Blueprint
import json
from werkzeug.wrappers import Response as ResponseWrapper

from multinet.user import load_user_from_cookie, filtered_user, delete_user_cookie
Expand All @@ -17,16 +18,16 @@
def user_info() -> ResponseWrapper:
"""Return the filtered user object."""

forbidden = make_response("null", 403)
logged_out = make_response(json.dumps(None), 200)

cookie = session.get(MULTINET_COOKIE)
if cookie is None:
return forbidden
return logged_out

user = load_user_from_cookie(cookie)
if user is None:
session.pop(MULTINET_COOKIE, None)
return forbidden
return logged_out

return make_response(asdict(filtered_user(user)))

Expand Down

0 comments on commit 0a6dcf8

Please sign in to comment.