Merge pull request #168 from multinet-app/add_pep8_naming

Add flake8 plugin for pep8 naming

Pipfile

@@ -26,6 +26,7 @@ pytest-cov = "==2.7.1"
 pytest-xdist = "==1.29.0"
 recommonmark = "==0.5.0"
 pre-commit = "==1.18.2"
+pep8-naming = "*"
 
 [requires]
 python_version = "3.7"

multinet/api.py

@@ -124,12 +124,12 @@ def create_graph(workspace, graph, node_tables=None, edge_table=None):
     if missing:
         raise RequiredParamsMissing(missing)
 
-    loadedWorkspace = db.db(workspace)
-    if loadedWorkspace.has_graph(graph):
+    loaded_workspace = db.db(workspace)
+    if loaded_workspace.has_graph(graph):
         raise AlreadyExists("Graph", graph)
 
-    existing_tables = set([x["name"] for x in loadedWorkspace.collections()])
-    edges = loadedWorkspace.collection(edge_table).all()
+    existing_tables = set([x["name"] for x in loaded_workspace.collections()])
+    edges = loaded_workspace.collection(edge_table).all()
 
     # Iterate through each edge and check for undefined tables
     errors = []
@@ -153,7 +153,7 @@ def create_graph(workspace, graph, node_tables=None, edge_table=None):
     # Iterate through each node table and check for nonexistent keys
     for table in valid_tables:
         existing_keys = set(
-            [x["_key"] for x in loadedWorkspace.collection(table).all()]
+            [x["_key"] for x in loaded_workspace.collection(table).all()]
         )
         nonexistent_keys = valid_tables[table] - existing_keys
 

multinet/uploaders/csv.py

@@ -19,13 +19,13 @@ def validate_csv(rows):
     if "_key" in fieldnames:
         # Node Table, check for key uniqueness
         keys = [row["_key"] for row in rows]
-        uniqueKeys = set()
+        unique_keys = set()
         duplicates = set()
         for key in keys:
-            if key in uniqueKeys:
+            if key in unique_keys:
                 duplicates.add(key)
             else:
-                uniqueKeys.add(key)
+                unique_keys.add(key)
 
         if len(duplicates) > 0:
             return {"error": "duplicate", "detail": list(duplicates)}