Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to get SHA/MD5 values of Timecyc.dat file (possibly other modded files aswell) for onPlayerModInfo #1008

Open
ffsPLASMA opened this issue Jun 25, 2019 · 14 comments
Labels
enhancement New feature or request
Milestone

Comments

@ffsPLASMA
Copy link

Is your feature request related to a problem? Please describe.
Recently MTA provided a new security update to block modded Timecyc.dat file to prevent possible cheating. The issue is many, if not all ENB mods use the Timecyc.dat file to enhance visuals.

Describe the solution you'd like
Add the possibility to get SHA/MD5 values of modded Timecyc.dat file (possibly other modded files aswell) on onPlayerModInfo event, so server can check against local whitelist and decide to keep or kick the player.

Describe alternatives you've considered
Either disable the SD for Timecyc.dat file or add a "global" MTA whitelist system.

@ffsPLASMA ffsPLASMA added the enhancement New feature or request label Jun 25, 2019
@Dutchman101
Copy link
Member

Dutchman101 commented Jun 25, 2019

I like your idea of being able to get the hash of a client's timecyc.dat, so servers can even override their own standard blocking of timecyc mods (not having allowed it entirely because they wish to remain protected against unfair advantage). This way server scripters can approve timecyc.dat's that they certify won't impact their gamemode in specific.

Also the last remark lands us directly at the problem with a global whitelist:

It would be hard to impossible for MTA staff to judge and approve acceptable timecyc.dat's (as they can impact different gamemodes in different ways, there's no such thing as 'low risk'), we can never give a stamp that says 'safe for all competetive gamemodes', so there would sometimes be additions that are short-sighted.

*Note: if this gets done based on servers getting the hash for whitelisting, i would advise that if it's whitelisted players wouldn't need to toggle "Use modified GTA files" , so that the file would be treated as regular. This spares the player some time and effort in understanding how to get it working once the server whitelists their file.

@qaisjp
Copy link
Contributor

qaisjp commented Jun 25, 2019

add a "global" MTA whitelist system

I think it is reasonable for us to whitelist a couple files from known mods.

There's no guarantee it will be perfect and that's perfectly fine as long as the server can override our whitelist.

@qaisjp qaisjp added this to the Backlog milestone Jun 25, 2019
@ccw808
Copy link
Member

ccw808 commented Jun 25, 2019

Please supply all the ENB timecyc.dat variations for us to examine

@ffsPLASMA
Copy link
Author

ENB Mod: Sa_DirectX 2.0 (Version 0.313)

timecyc.zip

@qaisjp
Copy link
Contributor

qaisjp commented Jul 10, 2019

ENB Mod: Sa_DirectX 2.0 (Version 0.313)

timecyc.zip

Thank very much — do you have a link to this on the enb series website (or similar)?

@ffsPLASMA
Copy link
Author

ENB Mod: Sa_DirectX 2.0 (Version 0.313)
timecyc.zip

Thank very much — do you have a link to this on the enb series website (or similar)?

There you go pal :3
https://www.gtainside.com/en/sanandreas/mods/119369-sa-directx-2-0/

@patrikjuvonen
Copy link
Contributor

patrikjuvonen commented Jul 10, 2019

I think we could have a Wiki page with known good variations and servers could use that list as reference. We could also introduce such list in admin resource for example. I think us managing another global list is one more thing to maintain and look after when by design it is now up to server owners to do with as they please.

+1 to the checksum of the file though, makes a lot of sense to me.

@qaisjp
Copy link
Contributor

qaisjp commented Jul 10, 2019

I think we could have a Wiki page with known good variations and servers could use that list as reference. We could also introduce such list in admin resource for example. I think us managing another global list is one more thing to maintain and look after when by design it is now up to server owners to do with as they please.

+1 to the checksum of the file though, makes a lot of sense to me.

Hmm, yes, good point about adding it to the admin resource and letting a script manage this.

@DaminkOoO
Copy link

timecyc.zip

@DaminkOoO
Copy link

can this one be whitelisted ?

@Lpsd
Copy link
Member

Lpsd commented Sep 1, 2019

@PerkZ2001 this isn't a page to request a specific whitelist. If you read the thread, they are discussing the possibility of making it so that individual servers can choose to whitelist/allow specific timecyc files based on their checksum. This may be possible at some point in the future.

@DaminkOoO
Copy link

hmm what about this
timecyc (1).zip

@Lpsd
Copy link
Member

Lpsd commented Sep 1, 2019

Please read my message above. This is not a place to request whitelisting of timecyc files

@DaminkOoO
Copy link

ow sry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants