Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using a deprecated function name as a variable will print a warning #1435

Open
PlatinMTA opened this issue May 11, 2020 · 2 comments
Open

Using a deprecated function name as a variable will print a warning #1435

PlatinMTA opened this issue May 11, 2020 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@PlatinMTA
Copy link
Contributor

Describe the bug
You can't call a variable banIP or banSerial without getting an output on the server console/log.

To reproduce

-- serverside
banIP = "192.168.1.69"

Run that code and you will see and output similar to this:

[Server] banIP no longer works. Please manually update this. Refer to the wiki for details

Expected behaviour
It should only tell you that if you are trying to use the function banIP

Version
Server: r20488

Additional context
This isn't that important, but w/e

@PlatinMTA PlatinMTA added the bug Something isn't working label May 11, 2020
@Pirulax
Copy link
Contributor

Pirulax commented May 28, 2020

the outdated function checker is very bad, at best. It also flags other old function names, if it finds them in the code, probably using an strcmp, or something.

@Lpsd Lpsd added the good first issue Good for newcomers label May 28, 2020
@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Jun 14, 2022

https://github.com/multitheftauto/mtasa-blue/blob/master/Server/mods/deathmatch/logic/CResourceChecker.cpp#L721

void CResourceChecker::IssueLuaFunctionNameWarnings(const string& strFunctionName, const string& strFileName, const string& strResourceName, bool bClientScript,

what should be done about this checker?

@patrikjuvonen patrikjuvonen changed the title Using banIP or banSerial as a variable will give you a warning Using deprecated functions as a variable will print a warning Apr 16, 2023
@patrikjuvonen patrikjuvonen changed the title Using deprecated functions as a variable will print a warning Using a deprecated function name as a variable will print a warning Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants