I can't connect to my 1.5.6 server, for some stupid reason(a resource sets min client version, and I cant figure out which one)

Please, could someone run a few tests, and post the results here on 1.5.6 server and client?

Test values:

• 123
• 1234
• \0\0Hello
• 123\0
• hithere\0\0\0\0
• \0hi\0
• \0\0\0\0\0hi\0\0
• 123\0\0\0\0

They key can be anything. Let it be.. "c++20"

@Pirulax mtaserver.conf:

    <minclientversion></minclientversion>
    <minclientversion_auto_update>0</minclientversion_auto_update>

Edit: Oh a resource sets it - Nevermind

btw, the problem is that, now I've fixed en/decodeString as well, which has been returning wrong values since it was introduced. Should we keep backwards compatibility? Or just hope nobody tries comparing decoded strings?

Btw, since the old one used strnlen it strips all padding from the end, so I'll modify this one to be like that.

@Pirulax mtaserver.conf:

    <minclientversion></minclientversion>
    <minclientversion_auto_update>0</minclientversion_auto_update>

Edit: Oh a resource sets it - Nevermind

Actually, I'm not sure if it was a resource. I think this'll help, thanks!

New resource to test: utf1443.zip

We need to fix the padding in teaEncode, because with binary files 0's at the file end is totally acceptable.

Perhaps, maybe add a noTrim argument?

Lets try and fix the regression in this PR and we can discuss other problems with teaEncode in a separate issue.

Lets try and fix the regression in this PR and we can discuss other problems with teaEncode in a separate issue.

Agreed. Let's get this fixed yesterday