Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some OOP definitions are incorrect #1583

Open
qaisjp opened this issue Jul 29, 2020 · 0 comments
Open

Some OOP definitions are incorrect #1583

qaisjp opened this issue Jul 29, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@qaisjp
Copy link
Contributor

qaisjp commented Jul 29, 2020

Describe the bug

The following functions have incorrect OOP definitions and should return vectors:

Client

  • CLuaGUIDefs.cpp
    • guiGetPosition
    • guiGetSize
    • guiStaticImageGetNativeSize (missing)
  • CLuaObjectDefs.cpp
    • getObjectScale
  • CLuaPedDefs.cpp
    • getPedWeaponMuzzlePosition (missing)
  • CLuaPointLightDefs.cpp
    • getLightDirection
    • getWaterVertexPosition
  • CLuaRadarAreaDefs
    • getRadarAreaSize (it returns a vector for r.size only, it should also return a vector for r:getSize())
  • CLuaVehicleDefs.cpp
    • getVehicleTurretPosition
  • CLuaWaterDefs
    • getWaterVertexPosition

Server

  • CLuaPlayerDefs
    • getCameraMatrix
  • CLuaPointLightDefs
    • getLightDirection
  • CLuaRadarAreaDefs
    • getRadarAreaSize (as above, in Client)
  • CLuaTextDefs
    • textItemGetPosition
  • CLuaVehicleDefs
    • getVehicleTurretPosition
    • getVehicleRespawnPosition
    • getVehicleRespawnRotation
  • CLuaWaterDefs
    • getWaterVertexPosition

Expected behaviour

Lets take getVehicleTurretPosition as an example. It's in the above list, and that means we need to:

  • Ensure vehicle:getTurretPosition() returns a vector
  • Ensure vehicle.turretPosition returns a vector

Version

1.5.7 r20608

Additional context

This issue was created as part of #1582, which aims to resolve #1240.

@qaisjp qaisjp added the bug Something isn't working label Jul 29, 2020
@qaisjp qaisjp added this to the 1.6 milestone Jul 29, 2020
@botder botder modified the milestones: Next Release, Backlog Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants