toggleControl next_weapon and previous_weapon takes sniper zoom with Q and A!

[mihayy5]

Describe the bug
Toggling next_weapon and previous_weapon controls off will also toggle sniper zoom off with Q and A keys!
Note: Mouse wheel will still zoom in/out
next_weapon = zoom_in & previous_weapon = zoom_out

To reproduce

1. toggleControls off.
2. Take sniper.
3. Press Q or A to zoom in/out.
4. Doesn't work.

Expected behaviour
Expected to zoom in or out depending on the key.

Version
Latest version from the MTA website: 1.5.8
Server: 1.5.8-9.20881.0
Client: v1.5.8-release-20881

[androksi]

I can confirm the issue.

[Allerek]

Its most likely due to this check

mtasa-blue/Client/core/CKeyBinds.cpp

Line 1249 in 70272f9

if (bState || !GetMultiGTAControlState(pBind))

I'll check more about that later today.

[srslyyyy]

If i recall correctly disabling jump won't let you zoom as well when holding LSHIFT.

[Allerek]

mtasa-blue/Client/core/CKeyBinds.cpp

Line 1325 in 70272f9

if (pTemp->control->action == action)

^If we set the breakpoint here, with if statement to break only
"if action == ZOOM_IN"
and try to press Q, it wont break for some reason(breaks on if action == PREVIOUS_WEAPON). It looks like GTA Hardcoded 'NEXT/PREVIOUS Weapon' to ZOOM_IN/OUT.

Maybe we should make an IF statement with checking if player is using scope/zoom? Share your opinions.

[mihayy5]

I'm not used to cpp, but in the line you shared there is this check that checks

if (action == action)

But where does actually 'action' get defined ?

[Allerek]

I'm not used to cpp, but in the line you shared there is this check that checks

if (action == action)

But where does actually 'action' get defined ?

pTemp is temporary pointer to they keyBind that holds the same action as main key that was pressed, so ->action is its action, and

action is action of original key

mtasa-blue/Client/core/CKeyBinds.cpp

Line 1315 in 70272f9

eControllerAction action = pBind->control->action;

So this if statement is literally:
if temporaryKey have same action as action then proceed

[lopezloo]

After 4a4bcbc it's no longer possible to control zoom using next_weapon / previous_weapon binds.