Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Door & panel states (damage) not syncing for vehicles with custom model IDs #2571

Open
Fernando-A-Rocha opened this issue Mar 12, 2022 · 4 comments
Open

Door & panel states (damage) not syncing for vehicles with custom model IDs #2571

Fernando-A-Rocha opened this issue Mar 12, 2022 · 4 comments
Labels
bug Something isn't working
Projects
Known issues: custom model ID's

Comments

@Fernando-A-Rocha
Copy link
Contributor

engineRequestModel("vehicle") gives you a new vehicle model ID. Logically this ID needs to be applied to an element using setElementModel. You may also want to use engineFreeModel when the element streams out to save memory at some point.

I've noticed an issue while testing my newmodels resource related to visible damage on the vehicle not staying.

Door & panel damage that you can obtain on a vehicle by damaging it yourself or using setVehicleDoorState & setVehiclePanelState resets after the vehicle's model is changed.

This is problematic and can strongly be considered a bug as it's some unintended behavior.

Serverside sync should fix this issue.

Version
r21135
@Fernando-A-Rocha Fernando-A-Rocha added the bug Something isn't working label Mar 12, 2022
@Fernando-A-Rocha
Copy link
Contributor Author

See how to reproduce here

@Fernando-A-Rocha
Copy link
Contributor Author

Other important related issue: #1861

@TheNormalnij TheNormalnij mentioned this issue Jun 13, 2022
Open
Fernando-A-Rocha referenced this issue Feb 1, 2023
@BCG2000
Make CNetAPI::WriteVehiclePuresync() use parent model ID when syncing…
51d3288 
… vehicles added with engineRequestModel()
@Fernando-A-Rocha Fernando-A-Rocha changed the title Door & panel states not syncing after model change (related to engineRequestModel & engineFreeModel features) Door & panel states (damage) not syncing for vehicles with custom model IDs Feb 1, 2023
@Fernando-A-Rocha
Copy link
Contributor Author

@TheNormalnij Possible to fix this? Sorry for ping but this was created in march 2022 and more bugs related to allocated model IDs have been fixed recently, so this could be too?

@TheNormalnij
Copy link
Contributor

This should be fixed in #2533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
Known issues: custom model ID's
To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheNormalnij @Fernando-A-Rocha