Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engineRequestModel returns the texture names/elements of its parent ID when requested #2630

Open
1 task done
MrSol0 opened this issue May 25, 2022 · 5 comments
Open
1 task done
Labels
bug Something isn't working

Comments

@MrSol0
Copy link

MrSol0 commented May 25, 2022

Describe the bug

This bug relates to getting textures of a model generated by engineRequestModel, the issue is that engineGetVisibleTextureNames & engineGetModelTextures & engineGetModelTextureNames return textures of the ParentID of the model instead of the model itself.

Steps to reproduce

1- engineRequestModel with model id for example 579
2- get a new vehicle mod and replace the id generated from step 1, for example if you get model id 3 then engineLoadDFF & engineLoadTXD model 3 with any mod available online.
3- use for example engineGetModelTextureNames("3")
4- you will get textures of parent vehicle model 579 instead of the mod you replaced on model 3.

Version

No response

Additional context

No response

Relevant log output

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not security related.
@MrSol0 MrSol0 added the bug Something isn't working label May 25, 2022
@MrSol0 MrSol0 changed the title engineGetVisibleTextureNames & engineGetModelTextures & engineGetModelTextureNames, engineRequestModel issue engineRequestModel returns the texture names/elements of its parent ID when requested May 25, 2022
@Lpsd
Copy link
Member

Lpsd commented May 25, 2022

engineGetModelTextureNames / engineGetModelTextures grabs the textures from original SA models only.

There is no support in those functions for custom model textures. So it's not a bug, but rather functionality which hasn't been implemented and isn't supposed to work in the first place (that's how it's coded). Those functions existed way before engineRequestModel.

So this is technically a feature request, not an bug / issue report. Just for clarification :)

@MrSol0
Copy link
Author

MrSol0 commented May 25, 2022

engineGetModelTextureNames / engineGetModelTextures grabs the textures from original SA models only.

There is no support in those functions for custom model textures. So it's not a bug, but rather functionality which hasn't been implemented and isn't supposed to work in the first place (that's how it's coded). Those functions existed way before engineRequestModel.

So this is technically a feature request, not an bug / issue report. Just for clarification :)

Just for clarification it returns false information so it's techinically a bug, also if you replace for example a sultan with a ferrari, engineGetModelTextureNames will return the ferrari textures if the vehicle model ID is not custom not the original SA model textures as you stated.

@Lpsd
Copy link
Member

Lpsd commented May 25, 2022

Those functions were written before custom model / texture stuff as above, I'm talking on a technical level for other people investigating this issue in the code so they don't get the wrong idea. This point isn't to be argued.

@Fernando-A-Rocha
Copy link
Contributor

Hey @TheNormalnij I recently experimented with this and it's still a problem. Are you aware of this issue that I think you tried to avoid when you implemented engineRequestModel features?

@TheNormalnij
Copy link
Contributor

@Fernando-A-Rocha Hi!
Yes. engineRequestModel was MVP only with main functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants