Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix building removal #2637

Closed
wants to merge 4 commits into from
Closed

Fix building removal #2637

wants to merge 4 commits into from

Conversation

tederis
Copy link
Collaborator

@tederis tederis commented Jun 1, 2022 •
edited by patrikjuvonen
Loading

Fixes #2631. When radius passed is zero, it works as before. Otherwise it restores all models that intersect with a sphere of the specified radius. Not backward compatible, but there's no other way to do it.

TheNormalnij
TheNormalnij previously approved these changes Jun 5, 2022
View reviewed changes
@lopezloo lopezloo added the bug Something isn't working label Jun 10, 2022
@TheNormalnij TheNormalnij dismissed their stale review June 12, 2022 20:56

Has some bugs

@TheNormalnij
Copy link
Member

Does not work for me

Executing client-side command: removeWorldModel(1337, 10000, 0, 0, 0)
Command results: true [boolean], 9 [number]

Executing client-side command: restoreWorldModel(1337, 5, -2710, 972, 55)
Command results: true [boolean], 9 [number]

Executing client-side command: removeWorldModel(1337, 10000, 0, 0, 0)
Command results: true [boolean], 2 [number]

@patrikjuvonen patrikjuvonen added the feedback Further information is requested label Dec 30, 2022
@patrikjuvonen patrikjuvonen marked this pull request as draft December 30, 2022 19:33
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

This draft pull request is stale because it has been open for at least 90 days with no activity. Please continue on your draft pull request or it will be closed in 30 days automatically.

@github-actions github-actions bot added the stale Inactive for over 90 days, to be closed label Apr 3, 2023
@github-actions github-actions bot closed this May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

This draft pull request was closed because it has been marked stale for 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheNormalnij TheNormalnij TheNormalnij left review comments

Assignees
No one assigned
Labels
bug Something isn't working feedback Further information is requested stale Inactive for over 90 days, to be closed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'restoreWorldModel' does not use it's 'fRadius' argument
4 participants
@tederis @TheNormalnij @lopezloo @patrikjuvonen