Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volumetric shadows slighty darker #2778

Closed
1 task done
lopezloo opened this issue Oct 6, 2022 · 4 comments · Fixed by #2989
Closed
1 task done

Make volumetric shadows slighty darker #2778

lopezloo opened this issue Oct 6, 2022 · 4 comments · Fixed by #2989
Labels
enhancement New feature or request

Comments

@lopezloo
Copy link
Member

lopezloo commented Oct 6, 2022

Is your feature request related to a problem? Please describe.

Volumetric shadows look ugly IMO. These would look a lot better if were blurred and little darker like blob shadows and dynamic ped shadows. Blurring them may be hard but changing their color is one byte change.

Describe the solution you'd like

Make volumetric shadows a bit darker, maybe? It would be a breaking (?) change, like, it would be different than it is in single player, so we could discuss that but I think these would seriously look better.

Describe alternatives you've considered

No response

Additional context

This is how blob shadows look: https://i.imgur.com/IdIy20b.png
This is how it looks now (initial alpha set to 50): https://i.imgur.com/Mu1gEVL.png
This is how it looks with alpha set to 95:
https://i.imgur.com/xpB4Eeq.png
https://i.imgur.com/WqZ61bd.png

This is how it looks with alpha set to 85:
https://i.imgur.com/FKnUPBS.png

Security Policy

  • I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.
@lopezloo lopezloo added the enhancement New feature or request label Oct 6, 2022
@Lpsd
Copy link
Member

Lpsd commented Oct 6, 2022

Does this have to be a 'breaking' change? Surely we can have a function to enable/disable this (disabled by default)?

Edit: could have a function to set the shadow alpha?

@lopezloo
Copy link
Member Author

lopezloo commented Oct 6, 2022

We could introduce a function for that but I'm more interested in altering default behaviour.

@PlatinMTA
Copy link
Contributor

I would only like this if server owners are the ones to opt in to use this new settings. We should avoid making the same mistake we made with the lowering of shadows (even if no z-fighting would occur because of this change).

@lopezloo
Copy link
Member Author

Edit: could have a function to set the shadow alpha?

We could introduce cvar for that. That way it wouldn't be breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants