Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get/setEffectScale was added in 1.6 r7485, but should be merged in 1.5.5 nightlies #282

Closed
Einheit-101 opened this issue Jul 29, 2018 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Einheit-101
Copy link

get/setEffectScale() has been merged in 2015 according to this site:
https://wiki.multitheftauto.com/wiki/SetEffectScale

However there is no MTA 1.6 available and i think this function should be merged into current nightlies, there is no point in leaving this dead behind for over 3 years.

Does this code actually exist or did someone create a wiki article about something that has not been made yet?

@qaisjp
Copy link
Contributor

qaisjp commented Jul 29, 2018

I am not sure where you got 2015 from as the wiki page was created in 2017.

I can't find setEffectScale anywhere in the code and the wiki page references r7485 which contains commits unrelated to a setEffectScale function.

I vaguely remember the function existing... maybe this got lost when we moved to just having master and xp-vista? This is an odd one...

@patrikjuvonen
Copy link
Contributor

Might've been related to EIR branch or some other custom branch at the time.

@Timic3
Copy link
Contributor

Timic3 commented Jul 30, 2018

It was supposed to be implemented by the wiki page author, but he gave up.

@qaisjp
Copy link
Contributor

qaisjp commented Aug 2, 2018

@Einheit-101 if your questions have been answered, are you okay to close this issue?

@Einheit-101
Copy link
Author

Well this is unfortunate but yeah, it can be closed then.

@patrikjuvonen patrikjuvonen added wontfix feedback Further information is requested enhancement New feature or request and removed feedback Further information is requested labels Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants