Improve performance of tocolor

[CrosRoad95]

Is your feature request related to a problem? Please describe.

This function is very, very often used, on almost all servers in render loops,

mtasa-blue/Shared/mods/deathmatch/logic/luadefs/CLuaUtilDefs.cpp

Line 714 in 228f881

int CLuaUtilDefs::tocolor(lua_State* luaVM)

current implementation doing a lot of unnecessary things

Describe the solution you'd like

move implementation to lua to decrease context switch, example implementation:

function tocolor(r,g,b,a)
  return b + g * 256 + r * 256 * 256 + (a or 255) * 256 * 256 * 256;
end

Describe alternatives you've considered

/

Additional context

:cat

Security Policy

• I have read and understood the Security Policy and this issue is not about a cheat or security vulnerability.

[Xenius97]

Hi,
I've fixed your code, cause it could break sometimes (eg. if you use interpolate animations). Now works well.

function tocolor(r,g,b,a)
	return math.floor(b) + math.floor(g) * 256 + math.floor(r) * 256 * 256 + math.floor(a or 255) * 256 * 256 * 256;
end

[tederis]

It's a bad practice to invoke tocolor every frame [assuming that a color is immutable]. The result of this function should be cached somewhere. Or even better to use a hexadecimal number like 0xFF00FFFF.

[Einheit-101]

Hi, I've fixed your code, cause it could break sometimes (eg. if you use interpolate animations). Now works well.

function tocolor(r,g,b,a)
	return math.floor(b) + math.floor(g) * 256 + math.floor(r) * 256 * 256 + math.floor(a or 255) * 256 * 256 * 256;
end

Sorry, your "floor" ruins the whole optimization. Without floor its twice as fast as tocolor, but with floor its twice as slow. I highly suggest just checking for yourself that you dont put wrong arguments into this wrapper function instead of doing this check for every tocolor() call.

[thisdp]

It won't optimise speed, instead, it will decrease performance