Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failed! CModelInfoSA.cpp #3192

Closed
1 task done
Xenius97 opened this issue Sep 22, 2023 · 3 comments · Fixed by #3194
Closed
1 task done

Assertion failed! CModelInfoSA.cpp #3192

Xenius97 opened this issue Sep 22, 2023 · 3 comments · Fixed by #3194
Assignees
@TheNormalnij
Labels
bug Something isn't working

Comments

@Xenius97
Copy link
Contributor

Xenius97 commented Sep 22, 2023 •
edited

Describe the bug

After using engineRequestTXD and engineSetModelTXDID i get randomly this error and game crashing (disconnect or quit game)

image

Steps to reproduce

Use linked resource from #3153

Version

22195

Additional context

No response

Relevant log output

No response

Security Policy

  • I have read and understood the Security Policy and this issue is not security related.
@Xenius97 Xenius97 added the bug Something isn't working label Sep 22, 2023
@Xenius97
Copy link
Contributor Author

@TheNormalnij

mtasa-blue/Client/game_sa/CModelInfoSA.cpp

Line 817 in 1f7937b

assert(mi);

@botder
Copy link
Member

botder commented Sep 22, 2023

Introduced in commit 3e9a373. @TheNormalnij @Pirulax

@Pirulax
Copy link
Contributor

Pirulax commented Sep 22, 2023

If there's no model info, there's nothing to reset, so I think just adding an if (mi) guard would be enough

@TheNormalnij TheNormalnij self-assigned this Sep 23, 2023
TheNormalnij added a commit to TheNormalnij/mtasa-blue that referenced this issue Sep 23, 2023
@TheNormalnij
Fix assert when model info is missing multitheftauto#3192
32733ae
@TheNormalnij TheNormalnij mentioned this issue Sep 23, 2023
Merged
botder pushed a commit that referenced this issue Sep 23, 2023
@TheNormalnij
Fix assert when model info is missing (Fixes #3192, PR #3194)
d431e5e 
[skip ci]
MTABot pushed a commit that referenced this issue Sep 25, 2023
@github-actions
Synchronize changes from 1.6 master branch [ci skip]
783d7f0 
0b6908b breakpad: Fix build error on glibc > 2.33
d431e5e Fix assert when model info is missing (Fixes #3192, PR #3194)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheNormalnij TheNormalnij

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix assert when model info is missing TheNormalnij/mtasa-blue
4 participants
@Xenius97 @TheNormalnij @Pirulax @botder