-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onClientMarkerHit ignores element's interior #322
Comments
It's been like this forever. I don't see why it should be changed, also because it'll be backwards incompatible. Just keep doing the checks yourself. |
This is not the case on server side. Also I'm not sure anyone would ever expect for marker to work outside of intertior it's visible to and therefore requre a backwards compatibility for this. |
Well it should ! Test it again. This is why on(Client)MarkerHit gives you the matching dimension in your handler function. |
Obviously that's for dimension only, not interior. |
OH GOD ! Sorry for that I genuinely thought it was about dimension for some reasons. I read too fast sorry. |
Do you happen to know or have you tested how col shapes behave with different interiors? I'm thinking if adding a new parameter would be a good solution as then we'd still have backwards compatibility. We'd have to make it server-side as well, though. |
@patrikjuvonen you still want to work on this? or I can do it. |
@Unde-R Hey, I'm going to unassign this from myself. Feel free to work on it. I wouldn't personally mind e.g. 1.6 to fix this bug as such and break scripts that "exploit" the bug. For now though, a parameter must be added for backwards compatibility reasons. |
I have a client-side marker, placed into a non-zero interior, but onClientMarkerHit would still trigger if element in interior 0 enters the marker. I assume onClientColShapeHit has the same issue, though it's more evident with markers since they ignore hit element's height on the client side.
The text was updated successfully, but these errors were encountered: