Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onClientMarkerHit ignores element's interior #322

Open
Sergeanur opened this issue Aug 10, 2018 · 8 comments
Open

onClientMarkerHit ignores element's interior #322

Sergeanur opened this issue Aug 10, 2018 · 8 comments
Labels
bug Something isn't working
Milestone

Comments

@Sergeanur
Copy link
Contributor

I have a client-side marker, placed into a non-zero interior, but onClientMarkerHit would still trigger if element in interior 0 enters the marker. I assume onClientColShapeHit has the same issue, though it's more evident with markers since they ignore hit element's height on the client side.

@patrikjuvonen patrikjuvonen added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Aug 10, 2018
@patrikjuvonen
Copy link
Contributor

It's been like this forever. I don't see why it should be changed, also because it'll be backwards incompatible. Just keep doing the checks yourself.

@Sergeanur
Copy link
Contributor Author

This is not the case on server side. Also I'm not sure anyone would ever expect for marker to work outside of intertior it's visible to and therefore requre a backwards compatibility for this.

@Citizen01
Copy link
Member

Citizen01 commented Aug 11, 2018

This is not the case on server side.

Well it should ! Test it again. This is why on(Client)MarkerHit gives you the matching dimension in your handler function.

@Sergeanur
Copy link
Contributor Author

This is why on(Client)MarkerHit gives you the matching dimension in your handler function.

Obviously that's for dimension only, not interior.

@Citizen01
Copy link
Member

OH GOD ! Sorry for that I genuinely thought it was about dimension for some reasons. I read too fast sorry.

@patrikjuvonen patrikjuvonen added bug Something isn't working and removed enhancement New feature or request labels Sep 4, 2018
@patrikjuvonen
Copy link
Contributor

Do you happen to know or have you tested how col shapes behave with different interiors?

I'm thinking if adding a new parameter would be a good solution as then we'd still have backwards compatibility. We'd have to make it server-side as well, though.

@patrikjuvonen patrikjuvonen self-assigned this Sep 4, 2018
@patrikjuvonen patrikjuvonen added this to the 1.5.7 milestone Sep 4, 2018
@patrikjuvonen patrikjuvonen modified the milestones: 1.5.7, Backlog Nov 3, 2018
@Unde-R
Copy link
Contributor

Unde-R commented Sep 9, 2020

@patrikjuvonen you still want to work on this? or I can do it.
If so what are the plans, adding the third parameter to onClientMarkerHit/leave & onMarkerHit/Leave?

@patrikjuvonen
Copy link
Contributor

@patrikjuvonen you still want to work on this? or I can do it.
If so what are the plans, adding the third parameter to onClientMarkerHit/leave & onMarkerHit/Leave?

@Unde-R Hey, I'm going to unassign this from myself. Feel free to work on it. I wouldn't personally mind e.g. 1.6 to fix this bug as such and break scripts that "exploit" the bug. For now though, a parameter must be added for backwards compatibility reasons.

@patrikjuvonen patrikjuvonen removed their assignment Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants