Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some functions should accept result from tocolor as color instead/and separated r,g,b #419

Open
CrosRoad95 opened this issue Sep 5, 2018 · 1 comment
Open

Some functions should accept result from tocolor as color instead/and separated r,g,b #419

CrosRoad95 opened this issue Sep 5, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
Backlog

Comments

@CrosRoad95
Copy link
Contributor

CrosRoad95 commented Sep 5, 2018 •
edited by patrikjuvonen
Loading

Is your feature request related to a problem? Please describe.
Some function accept r,g,b as 3 arguments, some need tocolor and 1 argument.

Describe the solution you'd like
This should be standardized and every funciton that accept color, should accept result from tocolor.

Describe alternatives you've considered

Additional context
few functions that accept r,g,b instead of single number:
outputChatBox, dxSetPixelColor, setBlipColor, guiGridListSetItemColor

Related to 240d562 in #263
@patrikjuvonen patrikjuvonen self-assigned this Sep 5, 2018
@patrikjuvonen patrikjuvonen added the enhancement New feature or request label Sep 5, 2018
@patrikjuvonen patrikjuvonen added this to the Backlog milestone Sep 5, 2018
@qaisjp
Copy link
Contributor

qaisjp commented Sep 5, 2018

I looked into doing this a while ago (for 1.4, or whenever OOP came out) and concluded that a Color class would be best.

@patrikjuvonen patrikjuvonen changed the title Some functions should accept result from tocolor as color instead/and separeted r,g,b Some functions should accept result from tocolor as color instead/and separated r,g,b Sep 5, 2018
@patrikjuvonen patrikjuvonen mentioned this issue Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@qaisjp @CrosRoad95 @patrikjuvonen