-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #423: setRadioChannel doesn't work when outside a vehicle #753
Fix #423: setRadioChannel doesn't work when outside a vehicle #753
Conversation
Unfortunately I can't reproduce a fix using your patch (i.e your patch does not fix anything). I am using a stripped radio version of GTASA, though. I'll try and re-test with full radio. Interestingly, both before and after applying this patch, the following problem occurs: setRadioChannel breaks stadium audio
|
Thanks for testing. There appears to be two issues, the latter being that once you start the radio (call to StartRadio), it will keep the radio on until you manually turn it off. I could try making it so that once you enter an area with an ambience track, it will stop the radio automatically and hence enables the ambience track. The fact that the radio doesn't turn on is weird, I'll test around a bit more. Where did you spawn? Is it the Steam version or some other version? I'm wondering if this has to do with some wrong offsets like with the radio class we had to do some tweaking. |
Happens with play's pirate ship spawn, as well as Easter Bay Airport in San Fierro. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs secondary review from @multitheftauto/blue-collaborators
Scratch that - it still doesn't work reliably, even with regular music. I don't know why it did work that one time. Can anyone else reproduce this?
Odd, I can't seem to reproduce that issue even without those files. |
I am no longer committed to working this issue so I'm closing this PR. Hopefully some of the work could be of use to someone else in the future. |
Fixes an issue where setRadioChannel function doesn't work on first try. You will have to enter a car or initialize an ambient track such as a stadium interior radio. This PR will initialize the ambience track manager by calling its
Service
method. It appears to fix the issue.Feel free to comment on what should be done instead, this is my first time working with asm injection stuff.