Refactor dxDrawCircle to use primitives queue, fix it's postGui issues #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 30, 2018
| fStartAngle = D3DXToRadian(fStartAngle); | ||
| fStopAngle = D3DXToRadian(fStopAngle); | ||
| // Calculate each segment angle | ||
| const float kfSegmentAngle = (fStopAngle - fStartAngle) / (siSegments-1); |
There was a problem hiding this comment.
I remember removing -1 in (siSegments-1), and it worked without any issues. Any reason for adding it back?
There was a problem hiding this comment.
Instead of floating point based loop, i made it to use exactly the amount of segments specified in dxDrawCircle call, that required adding -1 again
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #432, #431.
As the title suggest, this pull request forces dxDrawCircle to use primitives drawing, and fixes it's postGui issues. It also includes a bit of general code cleanup and removal of unnecessary vertices creation. I tried to test most of the common scenarios with that, and couldn't find any issues.