Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't change CEF volume in settings or setBrowserVolume #451

Open
ArranTuna opened this issue Sep 11, 2018 · 0 comments
Open

Can't change CEF volume in settings or setBrowserVolume #451

ArranTuna opened this issue Sep 11, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@ArranTuna
Copy link
Collaborator

ArranTuna commented Sep 11, 2018

Describe the bug
For instance you are playing a youtube video via CEF and you want to lower its volume, but you can't because changing the MTA volume doesn't affect CEF's volume.

myonlake / @patrikjuvonen said:
This is somewhat difficult to make in the CWebView class. Mute state or volume state aren't really resetting as supposed to on YouTube for example. This is because we're injecting our JavaScript onto the webpage which might be overriding it. So we're not actually in control.

There is also a comment about this in code:

Since the necessary interfaces of the core audio API were introduced in Win7, we've to fallback to HTML5 audio

Also regarding the mute on minimize feature: we need to store that as a separate boolean because the webpage might have HTML5 elements that already have volume/muted attributes, so we're overriding them upon minimize and volume control unless we have a separate minimize setter/getter.

I suppose if we drop XP support at some point in the future, we'll be able to make this work the right way without the HTML5 "hack".

To Reproduce
unstated

Expected behavior
Change volume of CEF (settings or setBrowserVolume)

Screenshots
If applicable, add screenshots to help explain your problem.

MTA Client (please complete the following information):
unstated

MTA Server (please complete the following information):
unstated

Additional context

@ArranTuna ArranTuna added the bug Something isn't working label Sep 11, 2018
@botder botder added this to the Backlog milestone Mar 3, 2019
@patrikjuvonen patrikjuvonen changed the title Can't change CEF volume in settings Can't change CEF volume in settings or setBrowserVolume Feb 6, 2021
@patrikjuvonen patrikjuvonen removed their assignment Jun 12, 2023
@patrikjuvonen patrikjuvonen removed this from the Next Release (1.6.1) milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants