Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailers desync #910

Open
Pirulax opened this issue May 2, 2019 · 8 comments
Open

Trailers desync #910

Pirulax opened this issue May 2, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@Pirulax
Copy link
Contributor

Pirulax commented May 2, 2019

Describe the bug
erorr404 said:

Talidan and I were playing around with trucks and trailers today, and several times the trailers became desynced. For example, I saw his truck without the trailer, even though it was on his screen. When he detached it, it disappeared from his screen as well.

To reproduce
Just create a Towtruck, attach a vehicle to it and go on the Road, it'll desync

Screenshots
https://www.youtube.com/watch?v=XD2JX9hZV2U

Version
Even in the newest

Additional context
Mantis link: https://bugs.mtasa.com/view.php?id=1655

@Pirulax Pirulax added the bug Something isn't working label May 2, 2019
@Pirulax
Copy link
Contributor Author

Pirulax commented May 2, 2019

What I think would be a good solution to this is to just sync if it's towed or not, because, as seen in the video, something deataches the towed vehicle.

The issue with trailers it, that they detach after a time as well.

@qaisjp qaisjp changed the title [Mantis Issue] 0001655: Trailers desync Trailers desync May 2, 2019
@Einheit-101
Copy link

Trailer sync is garbage even when a player is driving it, i have drivable trailers on my server and its ridiculous.

@PlatinMTA
Copy link
Contributor

This is bound to the <unoccupied_vehicle_sync_interval/> setting on mtaserver.conf, the vehicle attached doesn't update as quickly as it should, so you can see the trailer like behind of the vehicle meanwhile the player driving it won't see anything different. At least that it's what I think the problem comes from.

@StifflersMom
Copy link

StifflersMom commented May 13, 2019

I made the linked video for describing some issues with <unoccupied_vehicle_sync_interval/>. The idea behind this things were to sync the towed vehicle even with puresync like the towing vehicle.
On our server, we had a extreme low unoccupied_vehicle_sync_interval ( somewhat between 50 and 70, it's out of the limit range but it was functional). Also we made a resource, which uses detachTrailerFromVehicle client side for everyone except the tower. This made the trailer / towed vehicle update it's position more accurate than MTA itself.
For some unknown reason, all this tricky things were broken with some 1.5.6-????? version. Now we have ALWAYS desynced towed vehicles, except for the tower (wromg positions, wrong angle, ...).
I was talking to some devs before and they said, the towing sync and it's procedures are somewhat messed up - So someone will make a miracle come true and fix this and become a hero for all times 👯‍♂️

@tederis
Copy link
Collaborator

tederis commented Jul 31, 2019

I think, I have some progress in there
https://youtu.be/iFClCa_xaG4

@Citizen01
Copy link
Member

Where is your branch tederis ?

@tederis
Copy link
Collaborator

tederis commented Aug 5, 2019

Where is your branch tederis ?

It's still under development. The bug consists of two problems and I have fixed just one.

@tederis
Copy link
Collaborator

tederis commented Aug 17, 2019

Unfortunately I have no time at the moment to continue the research. So I made a simple fix that didn't eliminate the source of a problem but made a trailer's behavior much more satisfactory.
It can be found at https://github.com/tederis/mtasa-blue/tree/trailers_fix
I think it's just a half measure so I didn't dare to made a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants