Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like we have an off-by-one bug on the graph width calculation in LineChart #132

Closed
mum4k opened this issue Feb 18, 2019 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@mum4k
Copy link
Owner

mum4k commented Feb 18, 2019

Specifically here:

graphWidth := cvsAr.Dx() - yStart.X - 1

This statement makes the last cell inaccessible. Needs investigation though, as the rest of the infra and the unit test seem to account for this.

No serious impact, this will result in a larger than necessary gap (one cell) in some scenarios when drawing the line chart series.

@mum4k mum4k added the bug Something isn't working label Feb 18, 2019
@mum4k mum4k added the wontfix This will not be worked on label Apr 27, 2019
@mum4k
Copy link
Owner Author

mum4k commented Apr 27, 2019

Closing this until we see impact that would justify a fix.

@mum4k mum4k closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant