Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS X's setup.command in buildenv/1.3.x/osx/setup.command should have a terminal-friendly mode #24

Closed
mkrautz opened this issue May 5, 2016 · 1 comment

Comments

@mkrautz
Copy link
Contributor

mkrautz commented May 5, 2016

Instead of opening the Finder, it should detect if it's being run from a terminal directly, and source the 'env' file and put you in the buildenv -- it should also cd into ${MUMBLE_PREFIX}.

(This report also applies to buildenv/1.2.x, as well as the osx-universal variants...)

Note: this doesn't break CI, as CI uses ./setup.command --non-interactive (which just prints the BUILDENV_TARGET (which is equivalent to MUMBLE_PREFIX).

@mkrautz
Copy link
Contributor Author

mkrautz commented Dec 3, 2016

Not really a big problem.

@mkrautz mkrautz closed this as completed Dec 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant