Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for suppress-secrets, history-max and atomic options #29

Open
gmenuel opened this issue Apr 6, 2020 · 1 comment
Open

Add support for suppress-secrets, history-max and atomic options #29

gmenuel opened this issue Apr 6, 2020 · 1 comment

Comments

@gmenuel
Copy link

gmenuel commented Apr 6, 2020

Helm-x currently doesn't support having the --suppress-secrets option (but it seems to pass it anyway to helm) nor the --history-max option (introduced in helm3).

This cause problems for us when using helm-x with helmfile, especialy the --history-max option which is added by helmfile when calling helm-x.
@gmenuel gmenuel changed the title Add support for suppress-secrets and history-max options Add support for suppress-secrets, history-max and atomic options Apr 7, 2020
@gmenuel
Copy link
Author

gmenuel commented Apr 7, 2020

Also the --atomic option is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmenuel