Remove duplicated routes - Finishes #136 #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
afska
force-pushed
the
remove-duplicated-routes
branch
from
fe28a76
to
2a4e720
Compare
|
Looks good, but please notice that such changes are not backward compatible. We should introduce them in 6.x series. |
julian-berbel
force-pushed
the
master
branch
from
dd32d1d
to
aa58c19
Compare
julian-berbel
force-pushed
the
master
branch
from
55af5b9
to
96da102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #136
I removed all the duplicated endpoints prefixed with
/apiand unified the two students endpoints./courses/:course/studentsendpoints was adding:detached=>{:$exists=>false}to the query and the/api/courses/:course/studentswasn't. I'm assuming this was a bug, and we always want to add thedetachedfilter.