Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove teacher from Teacher collection when that permission is removed #180

Open
luchotc opened this issue Aug 21, 2019 · 3 comments
Open

Remove teacher from Teacher collection when that permission is removed #180

luchotc opened this issue Aug 21, 2019 · 3 comments

Comments

@luchotc
Copy link
Contributor

luchotc commented Aug 21, 2019

We should add teacher_removed method as well.
Is there any reason why we didn't do that? @flbulgarelli @fedescarpa
@flbulgarelli
Copy link
Member

This is most likely a bug

@flbulgarelli
Copy link
Member

It would be nice that instead of just removing it from the collection, we save the removal date somewhere.

@flbulgarelli
Copy link
Member

Perhaps a logical deletion is necessary here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flbulgarelli @luchotc