Number conversions

[mhermier]

My attempt at fixing issue #454. I try to inline functions with one call site, and try rationalize string to Num conversion. By doing so there is only one utility function used to convert numbers to strings, that is now shared in Num::fromString and the compiler. Note that it accepts scientific and hexadecimal values.

In extra, but commented, there are 2 extra features:

• Num::fromString would/should thow an error on invalid conversion, instead of returning null.
• wrenNewNumFromStringLength can be hardened to detect precision loss in hex format.

[munificent]

This looks pretty nice! A couple of questions:

• Is there a reason you moved wrenNewStringFromDouble() into the header and made it inline? It seems a little large to benefit from that.

• This means that Num.fromString() now accepts hex values too, right?

[mhermier]

Le 1 nov. 2017 00:22, "Bob Nystrom" <notifications@github.com> a écrit : This looks pretty nice! A couple of questions: - Is there a reason you moved wrenNewStringFromDouble() into the header and made it inline? It seems a little large to benefit from that. There is only one caller of it, no need to have it non static. - This means that Num.fromString() now accepts hex values too, right? Yes, there is also a commented check to ensure hex values fits in double as unsigned values, contrary to master.