Python 2-3 compatible utility scripts #530
Conversation
|
On second thought, I'll consider making them python2-3 compatible. Although python3 is the future (should've been the present for years now) it's probably better to only require python2 for now rather than both versions. |
|
Ironically, the bit where the code actually checked which version of Python was running was causing compatibility issues. |
jclc
changed the title
| System.print("two") | ||
|
|
||
| // Generate a compile error so we can test that the line number is correct. | ||
| + * // expect error |
There was a problem hiding this comment.
I think this file has been commited by mistake.
There was a problem hiding this comment.
I believe it used to have carriage returns right before newlines, which confused Python into thinking they were CRLF-newlines in utils/test.py. Since then I made it open the files as binary to circumvent that, so I suppose it doesn't really make much of a difference.
Looking at the original file now, my editor may have converted the CRs to CRLFs on its own before I checked it with a hex editor.
|
This seems to have been superseded by #541, closing. |
The shebang
#!/bin/env pythonis meant to point to python2 but some systems have it point to the newer and preferable python3, making these scripts fail when run without explicitly invoking Python. Since util/generate_docs.py already requires python3, it shouldn't be an issue to migrate all the scripts to the newer version. Removed unused imports and __future__ imports as well.Building libuv still requires python2 due to its build system, but there is some momentum to migrate it to python3.