munki-notifier does not respect UseNotificationCenterDays if set in /var/root or managed preference.

[weswhet]

munki/code/apps/munki-notifier/munki-notifier/AppDelegate.m

Lines 117 to 118 in 7154507

	plistRef = CFPreferencesCopyValue(
	CFSTR("UseNotificationCenterDays"), CFSTR("ManagedInstalls"), kCFPreferencesAnyUser, kCFPreferencesCurrentHost);

should be CFPreferencesCopyAppValue

[gregneagle]

Please see if this commit 42152f3 addresses your issue.

[weswhet]

Does not appear to resolve the issue.

[gregneagle]

Are you up to adding some debug logging, building and testing to figure out why?

[weswhet]

yeah, It doesn't look like there are any logs for munki-notifier otherwise I would have posted them already. Unless i'm missing them somewhere. Happy to test/build.

[gregneagle]

There aren't. You'd need to add NSLog() calls.

[gregneagle]

Oh, duh.
munki-notifier runs as the current GUI user. It can't read root preferences. The fix is still needed for managed preferences, though.

[gregneagle]

Nasty side-effect: a user could do defaults write ManagedInstalls UseNotificationCenterDays -int 10000, writing the pref to their own home dir, and now MSC will essentially never launch. Then they could also disable Notification Center notifications for MSC and then never ever be notified again.
So what's really needed is to use CFPreferencesAppValueIsForced -- if so, use the forced value returned by CFPreferencesCopyAppValue, otherwise use CFPreferencesCopyValue and target /Library/Preferences.

[gregneagle]

b59eeff implements this strategy.

[gregneagle]

I'm closing this issue as fixed for Managed Preferences and can't fix/works as designed as far as root preferences.