Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging level is getting ignored #6

Closed
marvin5300 opened this issue Feb 2, 2022 · 1 comment · Fixed by #7
Closed

Logging level is getting ignored #6

marvin5300 opened this issue Feb 2, 2022 · 1 comment · Fixed by #7
Assignees
@dtreffenstaedt
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
v1.0.0

Comments

@marvin5300
Copy link
Member

marvin5300 commented Feb 2, 2022 •
edited
Loading

Steps to reproduce:

  • call muonpi::log::setup(muonpi::log::Level::Error)
  • use muonp::log::debug() function

Expected behaviour:
Debug logs are not printed.

Observed behaviour:
Debug logs are printed.
Image Pasted at 2022-2-1 19-26
@marvin5300 marvin5300 added the bug Something isn't working label Feb 2, 2022
@marvin5300 marvin5300 added this to the v1.0.0 milestone Feb 2, 2022
@dtreffenstaedt dtreffenstaedt added the good first issue Good for newcomers label Feb 6, 2022
dtreffenstaedt pushed a commit that referenced this issue Feb 6, 2022
Changed logging level enum to be more structured
63cb1cd 
This fixes bug #6

The enum behaves more like flags now and produces the expected result.
@dtreffenstaedt dtreffenstaedt mentioned this issue Feb 6, 2022
Merged
@dtreffenstaedt dtreffenstaedt linked a pull request Feb 6, 2022 that will close this issue
Bugfix/issue 6 #7
Merged
@marvin5300
Copy link
Member Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtreffenstaedt dtreffenstaedt

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Bugfix/issue 6 MuonPi/libmuonpi
2 participants
@marvin5300 @dtreffenstaedt