You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed that in TxQuantize.cpp in TxQuantize::quantize, there is a section of code with the relevant parts:
for (i = 0; i < numcore - 1; i++) {
...
if (i == numcore-1)
...
...
thrd[i] = SDL_CreateThread(QuantizeThreadFunc, "quantizer", ¶ms[i]);
...
}
for (i = 0; i < numcore; i++) {
SDL_WaitThread(thrd[i], NULL);
}
Should the first for loop have i < numcore?
I think the following are currently true:
The conditional in the body of the loop won't ever succeed.
SDL_WaitThread will get an uninitialized value.
I don't know how to exercise this function, but it didn't quite look right to me.
Thanks,
Corey
The text was updated successfully, but these errors were encountered:
I noticed that in TxQuantize.cpp in
TxQuantize::quantize
, there is a section of code with the relevant parts:Should the first
for
loop havei < numcore
?I think the following are currently true:
I don't know how to exercise this function, but it didn't quite look right to me.
Thanks,
Corey
The text was updated successfully, but these errors were encountered: