Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Upgrade TCR's Go build version to 1.21 #427

Closed
21 tasks done
mengdaming opened this issue Sep 12, 2023 · 0 comments · Fixed by #434
Closed
21 tasks done

[Feature]: Upgrade TCR's Go build version to 1.21 #427

mengdaming opened this issue Sep 12, 2023 · 0 comments · Fixed by #434
Assignees
@mengdaming
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code S Small

Comments

@mengdaming
Copy link
Contributor

mengdaming commented Sep 12, 2023 •
edited
Loading

Contact Details

damien.menanteau@gmail.com

Feature Request

TCR is currently built with Go 1.20, while version 1.21 has been here for several months already.

Feature Description

Upgrade go version in tcr module from 1.20 to 1.21.

We should check in particular that:

  • All existing toolchains still work as before
  • All GitHub actions work properly

Alternatives

Stick to Go 1.20

Additional Context

Go 1.21 release notes: https://go.dev/doc/go1.21

Code of Conduct

  • I agree to follow this project's Code of Conduct

To Do List

  • Upgrade go version to 1.21
    • Change go version to 1.21 in go modules
      • src/go.mod (tcr module)
      • tcr-doc/go.mod (tcr doc generation)
    • Change go version in GitHub actions
      • .github/workflows/go.yml
      • .github/workflows/golangci_lint.yml
      • .github/workflows/goreleaser.yml
    • Verify that the 3 steps pass on GitHub
      • Check build
      • Check lint
      • Check release (can only be done after changes are merged on main branch)
    • Update the development documentation
      • dev-doc/build.md
    • Update .golangci.yml
  • Test that there is no regression
    • Verify that build works
    • Verify that tests work
    • Verify that linter doesn't raise any problems
    • Test that new version works with all existing toolchain (cf. script tools/tcr/verify-tcr-examples.sh)
@mengdaming mengdaming added enhancement New feature or request S Small github_actions Pull requests that update GitHub Actions code labels Sep 12, 2023
@mengdaming mengdaming self-assigned this Sep 19, 2023
@mengdaming mengdaming mentioned this issue Sep 19, 2023
Merged
6 tasks
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Upgrade TCR's go build version to 1.21
b06eb06
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Upgrade Go examples to go 1.21
d91b774
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Run go mod tidy
c25080a
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Add go workspace file to examples directory
12c4159 
- To keep it separate from go tool workspace itself
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Upgrade TCR's go build version to 1.21
807d955
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Upgrade Go examples to go 1.21
5f57dba
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Run go mod tidy
b4967ca
mengdaming added a commit that referenced this issue Sep 19, 2023
@mengdaming
[#427] Add go workspace file to examples directory
12460fb 
- To keep it separate from go tool workspace itself
@mengdaming mengdaming added the go Pull requests that update Go code label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mengdaming mengdaming

Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code S Small
Projects
TCR Enhancements & Bugs Follow Up
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

427-tcr-1-21 murex/TCR
Upgrade TCR's Go build version to 1.21 murex/TCR
1 participant
@mengdaming