Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black borders on the left/right on some configurations #588

Closed
nbarrett opened this issue Nov 24, 2023 · 3 comments
Closed

Black borders on the left/right on some configurations #588

nbarrett opened this issue Nov 24, 2023 · 3 comments

Comments

@nbarrett
Copy link

nbarrett commented Nov 24, 2023

What is the expected behavior?

  • First of all, thanks so much @MurhafSousli for a fantastic library!
  • When I choose imageSize = cover, slides should autosize so that there are no black borders on the left/right.
    image

What is the current behavior?

On the ngx-ramblers framework, which uses ngx-gallery as one of the rendering options:

  • when I choose thumbPosition = left example this happens correctly
  • when I choose thumbPosition = bottom example the rendering problem happens

I think the first one works okay because the width is reduced to under the required viewport of 1080px. Even if I set the width on the gallery component to 1080px it makes no difference.

What are the steps to reproduce?

See the above links

What is the use-case or motivation for changing an existing behavior?

Gallery doesn't look quite as good when there are black borders, and like the author of ngx-gallery, I'm want perfection!

Which versions are you using for the following packages?

Angular: 16.2.9
Angular CDK: 16.2.9
Angular CLI:16.2.9
Typescript: 4.9.5
Gallery: 11.0.0

Is there anything else we should know?

@MurhafSousli
Copy link
Owner

I cannot debug that examples you provided because autoplay is on, maybe if you provide a stackblitz

@nbarrett
Copy link
Author

Hello again @MurhafSousli - I've turned off autoplay on those 2 examples so it should be more debugable now 👍

@MurhafSousli
Copy link
Owner

MurhafSousli commented Nov 28, 2023

it appears you haven't set the imageSize to cover, it is set to contain by default. if you cannot set it to cover, try to reproduce your issue in a stackblitz and I can help you further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants